Specify locale in toLowerCase|toUpperCase #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
force-pushed
the
use-locale-string-upper-lower-case
branch
from
8d16d8c to
5b01c08
Compare
onobc
added
the
type: improvement
onobc
force-pushed
the
use-locale-string-upper-lower-case
branch
2 times, most recently
from
b202f5d to
6822fb0
Compare
This commit makes sure that all usages of String toLowerCase and toUpperCase specify a Locale (default of Locale.ROOT). Also, a checkstyle rule is added to prevent usage of the no-arg variant of String toLowerCase and toUpperCase.
onobc
force-pushed
the
use-locale-string-upper-lower-case
branch
from
6822fb0 to
871ca72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes sure that all usages of String toLowerCase and toUpperCase specify a Locale (default of Locale.ROOT).
Also, add a checkstyle rule to prevent usage of the no-arg variant of String toLowerCase and toUpperCase.