Skip to content

Add concurrency to PulsarContainerProperties #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Sep 3, 2024

This commit adds concurrency property to PulsarContainerProperties instead of managing it directly on
ConcurrentPulsarListenerContainerFactory, which provides consistency with both reactive counterpart and container properties in general.

Resolves: gh-820

This commit adds concurrency property to `PulsarContainerProperties`
instead of managing it directly on
`ConcurrentPulsarListenerContainerFactory`, which provides consistency
with both reactive counterpart and container properties in general.

Resolves: spring-projectsgh-820
Copy link
Collaborator

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the improvement @vpavic

@onobc onobc merged commit bec9318 into spring-projects:main Sep 3, 2024
6 checks passed
@vpavic vpavic deleted the gh-820 branch September 4, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listener concurrency attribute is inconsistent
2 participants