Detect M1 mac in test and substitute container image (#57) #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
reviewed
Aug 29, 2022
| @@ -38,4 +39,18 @@ protected static String getHttpServiceUrl() { | |||
| return PULSAR_CONTAINER.getHttpServiceUrl(); | |||
| } | |||
|
|
|||
| private static boolean isRunningOnMacM1() { | |||
There was a problem hiding this comment.
It uses the JVMs system properties to detect the M1 architecture.
This solution will fail if the JVM is running through Rosetta emulation. Other approaches that are independent of the JVM suffer similar problems (see this question about detecting the M1 from the cli for example) so I believe there is no really good solution for this edge case.
I think this is a pragmatic choice. We could later provide an env var that users in the "rosetta" group could set as an override/last resort. Again, I think this is fine for now.
If we start needing to do this same logic in other places we could add something like MacM1Detector that encapsulates how we determine this info.
onobc
reviewed
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a best-effort solution for issue #57.
It uses the JVMs system properties to detect the M1 architecture.
This solution will fail if the JVM is running through Rosetta emulation. Other approaches that are independent of the JVM suffer similar problems (see this question about detecting the M1 from the cli for example) so I believe there is no really good solution for this edge case.