Polish reference docs #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove hardcoded code where possible - Link to auto-generated config props rather than hardcoded tables - Simplify some wording
sobychacko
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sobychacko I still need to do the "Producer Factory Caching" and will do that tomorrow am. But I wanted to get this round of mods out there asap.
If you want to view the output locally then do these steps:
./gradlew clean build -x testfrom the root dir./spring-pulsar-docs/build/docs/asciidocMultipage/pulsar.htmlI think you will like what you see.
ℹ️ the next thing we need to do is pull the inline code in the doc out into the
docs/srcwhere possible and include source for the bigger examples. Otherwise it will get stale quickly.