Skip to content

Deprecate (Reactive)PulsarListenerEndpointAdapter #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Nov 9, 2023

This commit deprecates PulsarListenerEndpointAdapter and ReactivePulsarListenerEndpointAdapter in favor of default methods on ListenerEndpoint and its subinterfaces, which makes it a bit easier to provide custom ListenerEndpoint implementations.

This commit deprecates PulsarListenerEndpointAdapter and
ReactivePulsarListenerEndpointAdapter in favor of default methods on
ListenerEndpoint and its subinterfaces, which makes it a bit easier to
provide custom ListenerEndpoint implementations.
@onobc
Copy link
Collaborator

onobc commented Nov 10, 2023

Thanks for the PR @vpavic ,

The listener hierarchy side of things is a bit messy currently and refactorings like these are much appreciated. That being said, we are currently in RC and will do a 1.0.0-GA on 2023-11-20. As such, the only changes we are considering at this moment are bug fixes. We can consider the proposal after that though and I am more than happy to review it sooner.

Is the motivation of this change just a general improvement or it is unblocking you from doing something?

@vpavic
Copy link
Contributor Author

vpavic commented Nov 10, 2023

No worries, I understand the phase of the 1.0 is such that it's too late to accept this change immediately so close to the GA. There's always next minor release to target this at (that's also why I didn't refer any specific releases in the deprecation markers).

This isn't a blocker of any kind, just a convenience to have a simpler and more flexible listener hierarchy when implementing custom ListenerEndpoints.

@onobc onobc merged commit cf782af into spring-projects:main Dec 16, 2023
@onobc
Copy link
Collaborator

onobc commented Dec 16, 2023

Thanks for the contribution @vpavic !

@onobc onobc added this to the 1.0.1 milestone Dec 16, 2023
@onobc onobc added the type: improvement An improvement of implementation of existing feature label Dec 16, 2023
@vpavic vpavic deleted the deprecate-endpoint-adapter branch December 16, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement An improvement of implementation of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants