[hotfix] Fix README #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpreu
commented
Jul 26, 2022
| @@ -187,21 +186,20 @@ When injecting, note that, we can provide a specific type - `String` in this cas | |||
| If we have a need for a different `PulsarTemplate` with a different type in the same application, then we can add another injection with that type. | |||
| `PulsarTemplate` currently requires the application to set a default topic. | |||
| Once the topic is set, then we can call the various `send` methods on it. | |||
| In this example, we are calling the very basic `send` method that calls the synchronous send from the Pulsar producer internally that returns the `MessageId`. | |||
| In this example, we are calling the very basic synchronous `send` method that is internally forwarded to the Pulsar producer that returns the `MessageId`. | |||
There was a problem hiding this comment.
I changed this one because the code is not really calling the synchronous send from the Pulsar producer
sobychacko
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some minor issues in the README, such as control characters, doubles, and incorrect information