Add AOT support for Pulsar binder #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
onobc
commented
Mar 23, 2023
onobc
commented
- Adds native hints to allow the binder to run in a GraalVM native image.
- Adds native hints to allow the binder to run in a GraalVM native image.
onobc
commented
Mar 23, 2023
| @@ -29,10 +30,6 @@ | |||
| import org.apache.pulsar.client.impl.conf.ProducerConfigurationData; | |||
| import org.apache.pulsar.client.util.SecretsSerializer; | |||
| import org.apache.pulsar.common.protocol.Commands; | |||
| import org.apache.pulsar.shade.io.netty.buffer.AbstractByteBufAllocator; | |||
There was a problem hiding this comment.
I went ahead and moved these shaded ones in w/ their other shaded family members using the string API rather than direct imports.
onobc
commented
Mar 23, 2023
| "org.apache.pulsar.shade.io.netty.util.internal.shaded.org.jctools.queues.MpscArrayQueueProducerIndexField", | ||
| "org.apache.pulsar.shade.io.netty.util.internal.shaded.org.jctools.queues.MpscArrayQueueProducerLimitField", | ||
| "org.apache.pulsar.shade.io.netty.util.internal.shaded.org.jctools.queues.MpscArrayQueueConsumerIndexField") |
There was a problem hiding this comment.
I also compressed these into a single block. The value of trying to give the strictest access is not worth the initial effort. That can be left for a later tuning exercise.
|
@sobychacko I am going to merge this one so that the PR in AOT smoke tests can pick these changes up. I will gladly make any changes post merge if need be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.