Skip to content

Simplify defaults type mappings #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2023
Merged

Simplify defaults type mappings #377

merged 1 commit into from
Mar 22, 2023

Conversation

onobc
Copy link
Collaborator

@onobc onobc commented Mar 21, 2023

  • Remove redundant SchemaInfo.messageType as the key of the type mappings tells us that info

Before this change:

spring:
  pulsar:
    defaults:
      type-mappings:
        - message-type: com.acme.User
          schema-info:
            schema-type: AVRO
            message-type: com.acme.User

After this change:

spring:
  pulsar:
    defaults:
      type-mappings:
        - message-type: com.acme.User
          schema-info:
            schema-type: AVRO

@onobc onobc requested a review from sobychacko March 21, 2023 20:32
@onobc
Simplify defaults type mappings
97daa28 
* Remove redundant SchemaInfo.messageType as
  the key of the type mappings tells us that
  info
@onobc onobc force-pushed the cbono-simply-defaults-typemappings branch from 608ad3a to 97daa28 Compare March 21, 2023 20:34
@onobc onobc merged commit 19cc0ab into spring-projects:main Mar 22, 2023
@onobc onobc added this to the 0.2.0 milestone Mar 22, 2023
@onobc onobc deleted the cbono-simply-defaults-typemappings branch May 26, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobychacko sobychacko sobychacko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@onobc @sobychacko