Consolidate invokeHandler invocation #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
reviewed
Feb 17, 2023
| @@ -146,22 +145,9 @@ protected org.springframework.messaging.Message<?> toMessagingMessageFromReader( | |||
| return getMessageConverter().toMessageFromReader(record, reader, getType()); | |||
| } | |||
|
|
|||
| protected final Object invokeHandler(Object data, org.springframework.messaging.Message<?> message, | |||
There was a problem hiding this comment.
Basically the HandlerAdapter already supported the varargs and we were forcing this artficial constraint by permutations of different handle methods in the adapter. This is more flexible and lets us just pass the args and the handler adapter will find the proper handler, correct?
There was a problem hiding this comment.
Yep, that is correct. We were artificially making that extra hierarchy.
onobc
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
@sobychacko LGTM.
One question,
I take it that PulsarRecordMessagingMessageListenerAdapter was not being used by anything, correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.