Improve topic validation #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check if topic exists already for both partitioned and unpartitioned cases prior to creating. Fixes spring-projects#266
onobc
commented
Feb 16, 2023
| if (topic.isPartitioned()) { | ||
| List<String> matchingPartitions = getMatchingTopicPartitions(topic, existingTopicsInNamespace); | ||
| if (existingTopicsInNamespace.contains(topicName)) { |
There was a problem hiding this comment.
@sobychacko sorry, I just realized that I muddied the code change commit w/ "use var everywhere" commit. I think the change is small enough to decipher though. 2 parts, w/ this being the 1st part of the actual change.
This is part one of the change: "If there is already a non-partitioned topic out there - barf"
onobc
commented
Feb 16, 2023
| } | ||
| } | ||
| } | ||
| else { | ||
| if (!existingTopicsInNamespace.contains(topic.getFullyQualifiedTopicName())) { | ||
| this.logger.debug(() -> "Topic " + topic.getFullyQualifiedTopicName() + " does not exist."); | ||
| var matchingPartitions = getMatchingTopicPartitions(topic, existingTopicsInNamespace); |
There was a problem hiding this comment.
This is part two of the change: "If there is already a partitioned topic out there - barf"
onobc
commented
Feb 16, 2023
| @@ -52,6 +52,7 @@ | |||
| */ | |||
| @ExtendWith(SpringExtension.class) | |||
| @ContextConfiguration | |||
| @SuppressWarnings("JUnitMalformedDeclaration") | |||
There was a problem hiding this comment.
This prevents the warnings from IDEA on commit saying that test methods should declare method parameters (which IS valid w/ junit5).
sobychacko
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266