Pulsar Reader (imperative) Boot properties support #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
reviewed
Feb 7, 2023
| private String subscriptionRolePrefix; | ||
|
|
||
| /** | ||
| * If enabled, a consumer reads messages from a compacted topic rather than a full |
There was a problem hiding this comment.
For boolean config props so far we have used the form "Whether to " such as
* Whether to read messages from the compacted topic rather than the full message
* backlog.
onobc
reviewed
Feb 7, 2023
| public static class Reader { | ||
|
|
||
| /** | ||
| * Topic name. |
There was a problem hiding this comment.
[NIT] there can be multiples
onobc
reviewed
Feb 7, 2023
...oconfigure/src/test/java/org/springframework/pulsar/autoconfigure/PulsarPropertiesTests.java
Show resolved
Hide resolved
onobc
reviewed
Feb 7, 2023
| @@ -511,7 +511,7 @@ class ReaderPropertiesTests { | |||
| void readerProperties() { | |||
| Map<String, String> props = new HashMap<>(); | |||
|
|
|||
| props.put("spring.pulsar.reader.topic-names", "my-topic"); | |||
There was a problem hiding this comment.
Oh, sorry @sobychacko - I should have clarified. I meant that we typically use the relaxed named binding on the "left hand side" as that is typically what peepz will use in yml so it theoretically helps catch that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.