Skip to content

Use Schema.JSON instead of Schema.BYTES as default schema #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2023
Merged

Use Schema.JSON instead of Schema.BYTES as default schema #325

merged 3 commits into from
Feb 7, 2023

Conversation

cbornet
Copy link
Contributor

@cbornet cbornet commented Feb 6, 2023

Fix #323

@cbornet cbornet closed this Feb 6, 2023
@cbornet cbornet reopened this Feb 6, 2023
onobc
onobc requested changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@onobc onobc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @cbornet. A couple of comments to address (or not) and then we can put this one in.

Although I don't think there is any mention of the defaults currently in the docs, do you mind taking a stroll through once the dust settles and update/add if needed/applicable? Thank you.

@cbornet cbornet force-pushed the default-json branch 2 times, most recently from 57da4c1 to b809df5 Compare February 7, 2023 12:31
@cbornet cbornet force-pushed the default-json branch 4 times, most recently from 6e759db to 999c03a Compare February 7, 2023 17:28
@cbornet cbornet requested a review from onobc February 7, 2023 17:35
onobc
onobc requested changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbornet - thx for the updates. looks good. I couple of minor comments to address.

@cbornet
Copy link
Contributor Author

cbornet commented Feb 7, 2023

do you mind taking a stroll through once the dust settles and update/add if needed/applicable?

Added some

@cbornet cbornet requested a review from onobc February 7, 2023 18:46
@onobc onobc merged commit 4da2f50 into spring-projects:main Feb 7, 2023
@cbornet cbornet deleted the default-json branch February 7, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onobc onobc onobc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SchemaResolver default to Schema.JSON
2 participants
@cbornet @onobc