Tests for shared subscriptions #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
requested changes
Feb 2, 2023
There was a problem hiding this comment.
Nice test addition @sobychacko .
A couple of comments to address, but looks great.
| Awaitility.await().atMost(Duration.ofSeconds(30)).until(() -> latch2.await(10, TimeUnit.SECONDS)); | ||
| Awaitility.await().atMost(Duration.ofSeconds(30)).until(() -> latch3.await(10, TimeUnit.SECONDS)); | ||
|
|
||
| container1.stop(); |
There was a problem hiding this comment.
I know in the other listener tests we need to go back and put the resources in try-with-resources. I think it would be a good idea to do this now in this new test while there is only 3 tests in here. Wdyt?
| pulsarTemplate.newMessage("hello alice doe").sendAsync(); | ||
| pulsarTemplate.newMessage("hello buzz doe").sendAsync(); | ||
|
|
||
| Awaitility.await().atMost(Duration.ofSeconds(30)).until(() -> latch1.await(10, TimeUnit.SECONDS)); |
There was a problem hiding this comment.
I think we should line up the timeouts as in a failure case it will always wait 30s for each of these, rather than 10. I wonder if there is another way we can use Awaitility so that these awaits are not done in serial?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #305