Container pause/resume improvements #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When container is paused, ensure that we are not spinning CPU cycles by constantly trying to poll in a loop. When pausing the container, the polling waits until a condition is signaled by resuming. Resolves spring-projects#297
onobc
requested changes
Jan 31, 2023
There was a problem hiding this comment.
@sobychacko nice improvement and nice use of Lock/Condition for this. I added a couple comments.
...est/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainerTests.java
Outdated
Show resolved
Hide resolved
...est/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainerTests.java
Show resolved
Hide resolved
...est/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainerTests.java
Show resolved
Hide resolved
...src/main/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainer.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainer.java
Outdated
Show resolved
Hide resolved
onobc
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #297