Pulsar binder provisioner refactoring #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
reviewed
Jan 21, 2023
.../org/springframework/pulsar/spring/cloud/stream/binder/config/PulsarBinderConfiguration.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Jan 21, 2023
...mework/pulsar/spring/cloud/stream/binder/properties/PulsarBinderConfigurationProperties.java
Show resolved
Hide resolved
onobc
reviewed
Jan 21, 2023
...g/springframework/pulsar/spring/cloud/stream/binder/provisioning/PulsarTopicProvisioner.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Jan 21, 2023
...g/springframework/pulsar/spring/cloud/stream/binder/provisioning/PulsarTopicProvisioner.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Jan 21, 2023
...g/springframework/pulsar/spring/cloud/stream/binder/provisioning/PulsarTopicProvisioner.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Jan 21, 2023
...g/springframework/pulsar/spring/cloud/stream/binder/provisioning/PulsarTopicProvisioner.java
Show resolved
Hide resolved
onobc
reviewed
Jan 21, 2023
...g/springframework/pulsar/spring/cloud/stream/binder/provisioning/PulsarTopicProvisioner.java
Show resolved
Hide resolved
onobc
reviewed
Jan 21, 2023
.../test/java/org/springframework/pulsar/spring/cloud/stream/binder/PulsarBinderUtilsTests.java
Show resolved
Hide resolved
onobc
reviewed
Jan 21, 2023
.../java/org/springframework/pulsar/spring/cloud/stream/binder/PulsarTopicProvisionerTests.java
Outdated
Show resolved
Hide resolved
onobc
approved these changes
Jan 21, 2023
There was a problem hiding this comment.
@sobychacko looks good. My comments are pretty much nits about comments, naming etc.. Feel free to update what you agree w/ and then merge.
I'm not sure whats up w/ the CI though. Please take a look before merging.
sobychacko
force-pushed
the
provisioner-refactoring
branch
from
be695a2 to
c63d114
Compare
sobychacko
force-pushed
the
provisioner-refactoring
branch
from
281b5ef to
cbf4105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.