Listener endpoints use schema resolver #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
commented
Jan 20, 2023
| @SuppressWarnings({ "unchecked" }) | ||
| @Override | ||
| @SuppressWarnings("unchecked") | ||
| public <T> Schema<T> getSchema(SchemaType schemaType, @Nullable ResolvableType messageType) { |
There was a problem hiding this comment.
@sobychacko you can use this API in the binder and pass in null for messsageType which will give mappings for all of the primitives.
public Schema<?> toSchema(SchemaType schemaType) {
SchemaResolver schemaResolver = new DefaultSchemaResolver();
return schemaResolver.getSchema(schemaType, null);
}Then just need to make it possible for users to wire in custom mappings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the schema mapping code out of the method listener endpoints and into the SchemaResolver.
See #269