Add useKeyOrderedProcessing option to DefaultReactivePulsarMessageListenerContainer #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
reviewed
Nov 16, 2022
| .concurrent().concurrency(containerProperties.getConcurrency()) | ||
| .maxInflight(containerProperties.getMaxInFlight()); | ||
| if (containerProperties.isUseKeyOrderedProcessing()) { | ||
| concurrentPipelineBuilder.useKeyOrderedProcessing(); |
There was a problem hiding this comment.
[NOT-DIRECTLY-RELATED-WISHLIST] The fluent builder syntax is great.... until you have to do something conditionally. I want to explore a builder of the form field(T) and fieldIf(Supplier<T>, Condition<T>) sometime.
Ok, please resolve this comment once digested. Just sharing thoughts.
onobc
reviewed
Nov 16, 2022
| @@ -49,6 +49,8 @@ | |||
|
|
|||
| private int maxInFlight = 0; | |||
|
|
|||
| private boolean useKeyOrderedProcessing = false; | |||
There was a problem hiding this comment.
This reminds me that there is probably nothing stopping us from turning this into a simple record.
onobc
reviewed
Nov 16, 2022
| @@ -158,7 +160,8 @@ void containerProperties() throws Exception { | |||
|
|
|||
| assertThat(container).extracting("pipeline", InstanceOfAssertFactories.type(ReactiveMessagePipeline.class)) | |||
| .hasFieldOrPropertyWithValue("concurrency", 5).hasFieldOrPropertyWithValue("maxInflight", 6) | |||
| .hasFieldOrPropertyWithValue("handlingTimeout", Duration.ofMillis(7)); | |||
| .hasFieldOrPropertyWithValue("handlingTimeout", Duration.ofMillis(7)).extracting("groupingFunction") | |||
There was a problem hiding this comment.
Later we should consider breaking this test into smaller pieces as it is not directly clear that "setUseKeyOrderedProcessing" equates to "groupFunction == DMGF".
onobc
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.