Use Duration, DataSize and boxed types in PulsarProperties #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbornet
commented
Nov 3, 2022
|
|
||
| /** | ||
| * Pattern for topics the consumer subscribes to. | ||
| */ | ||
| private String topicsPattern; | ||
| private Pattern topicsPattern; |
There was a problem hiding this comment.
Used Pattern here since SB knows how to bind it
cbornet
commented
Nov 3, 2022
| @@ -111,12 +112,12 @@ public static class Consumer { | |||
| /** | |||
| * Comma-separated list of topics the consumer subscribes to. | |||
| */ | |||
| private String[] topics; | |||
| private Set<String> topics; | |||
There was a problem hiding this comment.
Used Set here since SB knows how to bind it.
cbornet
force-pushed
the
client-config
branch
2 times, most recently
from
e0d090c to
fda0022
Compare
cbornet
force-pushed
the
client-config
branch
from
fda0022 to
0249503
Compare
sobychacko
reviewed
Nov 3, 2022
| @@ -210,7 +210,7 @@ void customProducerInterceptorsOrderedProperly() { | |||
| void consumerBatchPropertiesAreHonored() { | |||
| contextRunner | |||
| .withPropertyValues("spring.pulsar.listener.max-num-messages=10", | |||
| "spring.pulsar.listener.max-num-bytes=101", "spring.pulsar.listener.batch-timeout-millis=50") | |||
| "spring.pulsar.listener.max-num-bytes=101B", "spring.pulsar.listener.batch-timeout=50ms") | |||
There was a problem hiding this comment.
Should we document these new formats in the doc?
There was a problem hiding this comment.
I think we are fine here as these should be self documenting in that they are config props and the doc is auto-generated. Also, using these types for Spring Boot config props is somewhat of a standard (or at least it is well-known to users).
|
@cbornet Overall, I like the approach that you took. Thank you for doing this cleanup. I added a minor doc comment above. |
onobc
requested changes
Nov 3, 2022
.../main/java/org/springframework/pulsar/autoconfigure/PulsarAnnotationDrivenConfiguration.java
Show resolved
Hide resolved
...t-autoconfigure/src/main/java/org/springframework/pulsar/autoconfigure/PulsarProperties.java
Show resolved
Hide resolved
...t-autoconfigure/src/main/java/org/springframework/pulsar/autoconfigure/PulsarProperties.java
Show resolved
Hide resolved
onobc
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #119