Listener container properties for batch receive. #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acknowledgment API cleanup.
onobc
reviewed
Sep 16, 2022
...t-autoconfigure/src/main/java/org/springframework/pulsar/autoconfigure/PulsarProperties.java
Show resolved
Hide resolved
onobc
reviewed
Sep 16, 2022
...t-autoconfigure/src/main/java/org/springframework/pulsar/autoconfigure/PulsarProperties.java
Show resolved
Hide resolved
onobc
reviewed
Sep 16, 2022
| @@ -360,6 +360,11 @@ else if (this.listener != null) { | |||
| else if (this.containerProperties.getAckMode() == AckMode.BATCH) { | |||
| this.nackableMessages.add(message.getMessageId()); | |||
| } | |||
| else { | |||
| throw new IllegalStateException( | |||
| "Exception occurred and not negatively acknowledged or handled properly", | |||
There was a problem hiding this comment.
Is there any action we can recommend for the user to take in this case? I guess, what is the outcome in this case (data loss?)
onobc
reviewed
Sep 16, 2022
...src/main/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainer.java
Show resolved
Hide resolved
onobc
reviewed
Sep 16, 2022
...t-autoconfigure/src/main/java/org/springframework/pulsar/autoconfigure/PulsarProperties.java
Show resolved
Hide resolved
onobc
requested changes
Sep 16, 2022
There was a problem hiding this comment.
@sobychacko I requested some minor changes around config props name/type/docs.
This was referenced Sep 16, 2022
|
Closed via eef1616 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acknowledgment API cleanup.