Skip to content

Avoid dependency on Apache Commons Logging from spring-modulith-docs artifact #1055

Closed
@patpatpat123

Description

@patpatpat123

Hello team,

Just wanted to reach out with a small enhancement request.
Currently, Spring modulith is depending on commons-logging.jar

[INFO] +- org.springframework.modulith:spring-modulith-docs:jar:1.3.2:compile
[INFO] |  +- com.structurizr:structurizr-core:jar:1.29.0:compile
[INFO] |  |  +- com.fasterxml.jackson.core:jackson-annotations:jar:2.18.2:compile
[INFO] |  |  +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
[INFO] |  |  \- commons-logging:commons-logging:jar:1.2:compile
[INFO] |  +- com.structurizr:structurizr-export:jar:1.19.0:compile

This would yield this message at each application startup:

Standard Commons Logging discovery in action with spring-jcl: please remove commons-logging.jar from classpath in order to avoid potential conflicts

So far, I am not seeing any use of commons-logging.jar by spring modulith doc.

While I understand each and every client, user of spring modulith docs can write its own exclusion block, and hence, relying and putting the burden on the user side, would it be possible to have the exclusion on spring modulith?

 <exclusions>
        <exclusion>
            <groupId>commons-logging</groupId>
            <artifactId>commons-logging</artifactId>
        </exclusion>
    </exclusions>

Thank you for your time reviewing this.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions