-
Notifications
You must be signed in to change notification settings - Fork 1.1k
spring-integration-jms minor changes: #9972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, find some review from me on the lines.
Thanks
...ng-integration-jms/src/main/java/org/springframework/integration/jms/AbstractJmsChannel.java
Outdated
Show resolved
Hide resolved
...ng-integration-jms/src/main/java/org/springframework/integration/jms/AbstractJmsChannel.java
Outdated
Show resolved
Hide resolved
...ng-integration-jms/src/main/java/org/springframework/integration/jms/DynamicJmsTemplate.java
Outdated
Show resolved
Hide resolved
...ng-integration-jms/src/main/java/org/springframework/integration/jms/DynamicJmsTemplate.java
Outdated
Show resolved
Hide resolved
...ng-integration-jms/src/main/java/org/springframework/integration/jms/DynamicJmsTemplate.java
Show resolved
Hide resolved
...ng-integration-jms/src/main/java/org/springframework/integration/jms/PollableJmsChannel.java
Outdated
Show resolved
Hide resolved
...tion-jms/src/main/java/org/springframework/integration/jms/config/JmsChannelFactoryBean.java
Outdated
Show resolved
Hide resolved
1. add Javadoc for few classes. 2. use pattern matching for instanceof Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
@mjd507 , thank you for contribution; looking forward for more! For the future: don't squash commits for PRs: it is much easier to review new changes and follow history. |
got it, thank you ❤️ |
most of the Javadoc are from the official website, hope the description is correct.