Skip to content

GH-8754: MessageBuilder.setExpirationDate(@Nullable) #8755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2023
Merged

GH-8754: MessageBuilder.setExpirationDate(@Nullable) #8755

merged 1 commit into from
Oct 10, 2023

Conversation

mrpiggi
Copy link
Contributor

@mrpiggi mrpiggi commented Oct 9, 2023

Fixes #8754

  • AbstractIntegrationMessageBuilder.setExpirationDate(@Nullable Long expirationDate)
  • MessageBuilder.setExpirationDate(@Nullable Long expirationDate)
  • MessageBuilder.setExpirationDate(@Nullable Date expirationDate)

Fixes #8754

* `AbstractIntegrationMessageBuilder.setExpirationDate(@nullable Long expirationDate)`
* `MessageBuilder.setExpirationDate(@nullable Long expirationDate)`
* `MessageBuilder.setExpirationDate(@nullable Date expirationDate)`
@artembilan
Copy link
Member

Nothing to complain about the change, but I wonder what drives you to worry about this missed @Nullable?
Do you work with Kotlin? Or what makes this old code breaking on your side?

Thanks

@artembilan artembilan merged commit 75fcdda into spring-projects:main Oct 10, 2023
@artembilan
Copy link
Member

... and cherry-picked to 6.1.x & 6.0.x

Thank you for contribution; looking forward for more!

@mrpiggi
Copy link
Contributor Author

mrpiggi commented Oct 11, 2023

No Kotlin, Java 17. And nothing breaks, only Intellij inspections are complaining about nullability problems. I suppressed those for SI at the appropriate statements. But as you encouraged me in #8750 to setup the project, I took the chance and searched my code for the corresponding comments.

@mrpiggi mrpiggi deleted the GH-8754 branch October 11, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MessageBuilder.setExpirationDate(expirationDate) should be marked as @Nullable
2 participants