GH-2971: Add LockRegistry.executeLocked() API
#8729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#2971 * Following best practice and well-known patterns with `Jdbc`, `Rest` or `Jms` templates, introduce `default` methods into `LockRegistry` interface to make it easier to perform tasks when within a lock. * Since all the required logic is now covered by those `LockRegistry.executeLocked()` methods, there is no need in the dedicated abstract `WhileLockedProcessor` class. Deprecated it for removal in the next version * Use a new `LockRegistry.executeLocked()` API in the `FileWritingMessageHandler` instead of just deprecated `WhileLockedProcessor` * To satisfy Java limitations for checked lambdas, introduce `CheckedCallable` and `CheckedRunnable` utilities similar to interfaces in the `io.micrometer.observation.Observation` * Change existing `CheckedFunction` to expose extra generic argument for `Throwable` * Add dedicated chapter for distributed lock into docs * Fix some links and typos in the docs
garyrussell
suggested changes
Sep 11, 2023
...tegration-core/src/main/java/org/springframework/integration/support/locks/LockRegistry.java
Outdated
Show resolved
Hide resolved
...tegration-core/src/main/java/org/springframework/integration/support/locks/LockRegistry.java
Outdated
Show resolved
Hide resolved
...tegration-core/src/main/java/org/springframework/integration/support/locks/LockRegistry.java
Outdated
Show resolved
Hide resolved
...tegration-core/src/main/java/org/springframework/integration/support/locks/LockRegistry.java
Outdated
Show resolved
Hide resolved
spring-integration-core/src/main/java/org/springframework/integration/util/CheckedCallable.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Gary Russell <grussell@vmware.com>
garyrussell
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2971
Jdbc,RestorJmstemplates, introducedefaultmethods intoLockRegistryinterface to make it easier to perform tasks when within a lock.LockRegistry.executeLocked()methods, there is no need in the dedicated abstractWhileLockedProcessorclass. Deprecated it for removal in the next versionLockRegistry.executeLocked()API in theFileWritingMessageHandlerinstead of just deprecatedWhileLockedProcessorCheckedCallableandCheckedRunnableutilities similar to interfaces in theio.micrometer.observation.ObservationCheckedFunctionto expose extra generic argument forThrowable