GH-8705 Expose errorOnTimeout on MessagingGateway #8712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#8705 an internal `MethodInvocationGateway` is a `MessagingGatewaySupport` extension with all the logic available there. One of the option introduced in `5.2.2` to be able to throw a `MessageTimeoutException` instead of returning `null` when no reply received in time from downstream flow * Expose an `errorOnTimeout` on the `@MessagingGateway` and `GatewayEndpointSpec` * Propagate this option from a `GatewayProxyFactoryBean` down to its internal `MethodInvocationGateway` implementation * Modify couple tests to react for `errorOnTimeout` set to `true` * Document the feature
garyrussell
suggested changes
Aug 22, 2023
...egration-core/src/main/java/org/springframework/integration/annotation/MessagingGateway.java
Outdated
Show resolved
Hide resolved
...-integration-core/src/main/java/org/springframework/integration/dsl/GatewayEndpointSpec.java
Outdated
Show resolved
Hide resolved
...-integration-core/src/main/java/org/springframework/integration/dsl/GatewayEndpointSpec.java
Outdated
Show resolved
Hide resolved
...tion-core/src/main/java/org/springframework/integration/gateway/GatewayProxyFactoryBean.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Gary Russell <grussell@vmware.com>
garyrussell
approved these changes
Aug 22, 2023
|
Please rebase and feel free to merge. |
|
Merged as 4e310bb after fixing conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8705
an internal
MethodInvocationGatewayis aMessagingGatewaySupportextension with all the logic available there.One of the option introduced in
5.2.2to be able to throw aMessageTimeoutExceptioninstead of returningnullwhen no reply received in time from downstream flowerrorOnTimeouton the@MessagingGatewayandGatewayEndpointSpecGatewayProxyFactoryBeandown to its internalMethodInvocationGatewayimplementationerrorOnTimeoutset totrue