GH-8708: Fix concurrency around SFTP client#8709
Merged
Merged
Conversation
Fixes spring-projects#8708 According to the `org.apache.sshd.common.channel.ChannelAsyncOutputStream.writeBuffer()` JavaDocs cannot be used concurrently. * Introduce internal `DefaultSftpSessionFactory.ConcurrentSftpClient` extension of the `DefaultSftpClient` to set a `Lock` around `super.send(cmd, buffer);` * Remove lock from the `SftpSession` since it now is managed by the mentioned `ConcurrentSftpClient` **Cherry-pick to `6.1.x` & `6.0.x`**
garyrussell
approved these changes
Aug 22, 2023
Contributor
|
Cherry pick has conflicts due to sync changes; please back port. |
artembilan
added a commit
that referenced
this pull request
Aug 22, 2023
Fixes #8708 According to the `org.apache.sshd.common.channel.ChannelAsyncOutputStream.writeBuffer()` JavaDocs cannot be used concurrently. * Introduce internal `DefaultSftpSessionFactory.ConcurrentSftpClient` extension of the `DefaultSftpClient` to set a `Lock` around `super.send(cmd, buffer);` * Remove lock from the `SftpSession` since it now is managed by the mentioned `ConcurrentSftpClient` **Cherry-pick to `6.1.x` & `6.0.x`** # Conflicts: # spring-integration-sftp/src/main/java/org/springframework/integration/sftp/session/SftpSession.java
artembilan
added a commit
that referenced
this pull request
Aug 22, 2023
Fixes #8708 According to the `org.apache.sshd.common.channel.ChannelAsyncOutputStream.writeBuffer()` JavaDocs cannot be used concurrently. * Introduce internal `DefaultSftpSessionFactory.ConcurrentSftpClient` extension of the `DefaultSftpClient` to set a `Lock` around `super.send(cmd, buffer);` * Remove lock from the `SftpSession` since it now is managed by the mentioned `ConcurrentSftpClient` **Cherry-pick to `6.1.x` & `6.0.x`** # Conflicts: # spring-integration-sftp/src/main/java/org/springframework/integration/sftp/session/SftpSession.java
Member
Author
|
... and cherry-picked to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8708
According to the
org.apache.sshd.common.channel.ChannelAsyncOutputStream.writeBuffer()JavaDocs cannot be used concurrently.DefaultSftpSessionFactory.ConcurrentSftpClientextension of theDefaultSftpClientto set aLockaroundsuper.send(cmd, buffer);SftpSessionsince it now is managed by the mentionedConcurrentSftpClientCherry-pick to
6.1.x&6.0.x