Shutdown test executors in -core #2334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
garyrussell
commented
Jan 18, 2018
garyrussell
commented
- also add log adjuster for ftp test that sometimes fails
- don't use `ExecutorService` as `@Bean` - spring can't stop them - also add log adjuster for ftp test that sometimes fails
artembilan
approved these changes
Jan 19, 2018
| @@ -141,8 +142,8 @@ public void testReplyBeforeRequest() throws Exception { | |||
| handler.setOutputChannel(outputChannel); | |||
| handler.setBeanFactory(mock(BeanFactory.class)); | |||
| handler.afterPropertiesSet(); | |||
| Executors.newSingleThreadExecutor() | |||
| .execute(() -> handler.trigger(MessageBuilder.withPayload("bar").setCorrelationId("foo").build())); | |||
| ExecutorService exec = Executors.newSingleThreadExecutor(); | |||
There was a problem hiding this comment.
In the #2329 I went the way to expose a SimpleAsyncTaskExecutor as a class property do not instantiate per test and don't care about shutdown, but I think it really doesn't matter from test perspective.
So, merging...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.