Fix Kotlin DSL according to IDEA errors and suggestions #10307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not clear why it does not fail with Gradle, but right now it is not possible to build the project using IDEA compiler. Some of the suggestions are good and have led to the Nullability fixes in related Java DSL classes. The `Any` extension requirement for the generic argument of reified types is not clear, but works. The requirement to refine nullable Kotlin types is good. Somewhat related to: spring-projects#10083
cppwfs
requested changes
Aug 13, 2025
Contributor
cppwfs
left a comment
cppwfs
left a comment
There was a problem hiding this comment.
Looks great, I was a bit rusty on my Kotlin...
Just one simple question.
| * @return the spec. | ||
| */ | ||
| public <P> TransformerEndpointSpec expectedType(@Nullable Class<P> expectedType) { | ||
| public <P> TransformerEndpointSpec expectedType(Class<P> expectedType) { |
Contributor
There was a problem hiding this comment.
Question:
Is this a breaking change if we state that expectedType can not be reset to null. If so should we have a note about it?
Member
Author
There was a problem hiding this comment.
Reset?
This is part of Java DSL.
So, or you call this method in builder chain or not.
But if you do, it has to come with the value.
Why would one do:
.expectedType(String.class)
.expectedType(null)
?
Contributor
There was a problem hiding this comment.
I agree it doesn't make sense. But someone can do it.
Its not a show stopper in any shape. I just like to be annoying. 😆
cppwfs
approved these changes
Aug 13, 2025
Contributor
cppwfs
left a comment
cppwfs
left a comment
There was a problem hiding this comment.
LGTM! Thanks for investigating and fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not clear why it does not fail with Gradle, but right now it is not possible to build the project using IDEA compiler.
Some of the suggestions are good and have led to the Nullability fixes in related Java DSL classes. The
Anyextension requirement for the generic argument of reified types is not clear, but works. The requirement to refine nullable Kotlin types is good.Somewhat related to: #10083