Apply Nullability to stream module #10285
Conversation
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Since you are contributing a lot and I'd like to make our cooperation a bit smooth and productive, please, review this article about an importance of the commit message: https://cbea.ms/git-commit/.
What you shown so far is OK, but we could be a bit more convenient adding something like Related to: https://github.com/spring-projects/spring-integration/issues/10083 to fixes for that issue.
Other one issue - one PR could utilized Fixes: pattern.
I am also not fun of commit messages like Addressing PR review.
What PR is from the commit perspective?
Why should I search for PR to determine the reason of the change?
It is really better to express the change in the commit message.
Thanks for understanding!
| return "stream:stdin-channel-adapter(byte)"; | ||
| } | ||
|
|
||
| @SuppressWarnings("NullAway") |
There was a problem hiding this comment.
That's not.
This method indeed can return null.
Please, try to avoid @SuppressWarnings("NullAway") as much as possible.
It really hides a lot and we have to be vigilant what we are doing around our code.
The fix should be like this for this method signature:
@Override
protected byte @Nullable [] doReceive() {
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
2 participants
No description provided.