-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Apply Nullability to syslog module #10278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,8 @@ | |
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| import org.jspecify.annotations.Nullable; | ||
|
|
||
| import org.springframework.integration.JavaUtils; | ||
| import org.springframework.util.Assert; | ||
|
|
||
|
|
@@ -131,6 +133,7 @@ public RFC5424SyslogParser(boolean retainOriginal) { | |
| * @param r the reader. | ||
| * @return the timestamp. | ||
| */ | ||
| @Nullable | ||
| protected Object getTimestamp(Reader r) { | ||
|
|
||
| int c = r.getc(); | ||
|
|
@@ -152,6 +155,7 @@ protected Object getTimestamp(Reader r) { | |
| return dateBuilder.toString(); | ||
| } | ||
|
|
||
| @Nullable | ||
| private Object getStructuredData(Reader r) { | ||
|
||
| if (r.is(NILVALUE)) { | ||
| r.getc(); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| /** | ||
| * Provides classes for configuration - parsers, namespace handlers, factory beans. | ||
| */ | ||
| @org.jspecify.annotations.NullMarked | ||
| package org.springframework.integration.syslog.config; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,8 @@ | |
|
|
||
| package org.springframework.integration.syslog.inbound; | ||
|
|
||
| import org.jspecify.annotations.Nullable; | ||
|
|
||
| import org.springframework.context.ApplicationEventPublisher; | ||
| import org.springframework.context.ApplicationEventPublisherAware; | ||
| import org.springframework.integration.ip.tcp.connection.AbstractServerConnectionFactory; | ||
|
|
@@ -36,9 +38,10 @@ | |
| public class TcpSyslogReceivingChannelAdapter extends SyslogReceivingChannelAdapterSupport | ||
| implements TcpListener, ApplicationEventPublisherAware { | ||
|
|
||
| @SuppressWarnings("NullAway.Init") | ||
| private volatile AbstractServerConnectionFactory connectionFactory; | ||
|
|
||
| private volatile ApplicationEventPublisher applicationEventPublisher; | ||
| private volatile @Nullable ApplicationEventPublisher applicationEventPublisher; | ||
|
||
|
|
||
| /** | ||
| * @param connectionFactory The connection factory. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| /** | ||
| * Provides classes for inbound endpoints. | ||
| */ | ||
| @org.jspecify.annotations.NullMarked | ||
| package org.springframework.integration.syslog.inbound; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| /** | ||
| * Base package for Syslog Support. | ||
| */ | ||
| @org.jspecify.annotations.NullMarked | ||
| package org.springframework.integration.syslog; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but how have you missed to fix this one as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I missed it.