-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Apply Nullability to spring-integration-kafka
#10138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
related to spring-projects#10083 Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
related to spring-projects#10083 Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
Please, raise a GH issue in https://github.com/spring-projects/spring-kafka. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just couple nit-picks.
Overall this is great.
Thank you!
@@ -195,6 +196,7 @@ public boolean hasExecutorInterceptors() { | |||
return this.executorInterceptorsSize > 0; | |||
} | |||
|
|||
@SuppressWarnings("NullAway") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this one, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch, fixed
@@ -176,15 +179,16 @@ public boolean unsubscribe(MessageHandler handler) { | |||
return this.dispatcher.removeHandler(handler); | |||
} | |||
|
|||
@SuppressWarnings("NullAway") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May not on the whole class, but just that ctor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this warning, opened a PR in spring-kafka
, once that merged & published, we can try re-build this.
@@ -281,6 +281,7 @@ protected AttributeAccessor getErrorMessageAttributes(Message<?> message) { | |||
} | |||
} | |||
|
|||
@SuppressWarnings("NullAway") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here: let's see if we can have it only on ctor!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed, waiting for spring-kafka
Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
in local, I add |
Can you point us to the documentation on the matter, please? |
Ah! I see.
|
Hey, @mjd507 ! Any updates? Thanks |
related to #10083
Suppress warning for child classes which parent class (
RecordMessagingMessageListenerAdapter
orBatchMessagingMessageListenerAdapter
) are inspring-kafka
module, from the parent constructor,(Object bean, Method method)
are non null, but we give(null, null) inspring-integration-kafka
. not sure how to solve it.