Description
Current implementation of ControllerLinkBuilder
relies on Spring's ServletUriComponentsBuilder
to construct links. The problem with ServletUriComponentsBuilder
is that it is poorly designed (uses only static method calls), eliminating the possibility to extend and enhance the behaviour.
One typical scenario that I discovered yesterday:
Our tomcat server is hosted behind Apache. The client (browser) accesses a URL using www.example.com/path/to/resource
. However, because of the way Apache has been set up, it doesn't send along the Host
header value of www.example.com
to Tomcat. Instead, it sends the internal IP address. The original hostname of www.example.com
is set in an X-Forwarded-Host
header.
Now, because Spring's ServletUriComponentsBuilder
uses request.getServerName()
to construct the hostname part of the URL, any generated URLs will have the internal IP address instead of www.example.com
.
The only way I can fix this currently is by either:
- Creating a
HttpServletRequestWrapper
that takes the value ofX-Forwarded-Host
header and sets it toHost
header.
OR
- Rewriting
ControllerLinkBuilder
logic to not use Spring'sServletUriComponentsBuilder
.