Provide details when schema resource is invalid #307
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
dugenkui03
commented
Feb 24, 2022
|
|
||
| private final String resourceDescription; | ||
|
|
||
| private final SchemaProblem schemaProblem; |
There was a problem hiding this comment.
The SchemaProblem will be changed from internal to publicApi, we are free to use it, details in issues 2734;
dugenkui03
commented
Feb 24, 2022
| @@ -193,6 +194,9 @@ private TypeDefinitionRegistry parseSchemaResource(Resource schemaResource) { | |||
| catch (IOException ex) { | |||
| throw new IllegalArgumentException("Failed to load schema resource: " + schemaResource); | |||
| } | |||
| catch (SchemaProblem ex) { | |||
| throw new InvalidSchemaResourceException(schemaResource.getDescription(), ex); | |||
There was a problem hiding this comment.
The reason to create InvalidSchemaResourceException is that I think the 'wrong schema config' not match the semantic of IllegalArgumentException.
bclozel
added
type: enhancement
|
Thanks for your contribution! I've simplified a bit things here since we don't need to rely on a particular graphql-java exception. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details about this PR in #304