Add null check to enable creation of triggers without JobDetail. #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: SPR-13604
|
Thanks for the PR: this was fixed as part of 2970065 (I see no reason to not set the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows SimpleTriggerFactoryBean and CronTriggerFactoryBean to create triggers without associated job details. This is something that we need in our project (we are using spring to configure triggers, but we associate them with jobs programmatically) and it worked fine in Spring 3.x.
Issue: SPR-13604
I have signed and agree to the terms of the Spring Individual Contributor
License Agreement.