Skip to content

typo: InstrumentedMethodTests test method #35824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

typo: InstrumentedMethodTests test method #35824

wants to merge 1 commit into from

Conversation

@behappyleee
Copy link

@behappyleee behappyleee commented Nov 15, 2025

InstrumentedMethodTests.java test class typo
typo Whem -> When

Thanks :)

@behappyleee
typo: classGetConstructorsShouldNotMatchWhemMissingTypeHint -> classG…
c191a54 
…etConstructorsShouldNotMatchWhenMissingTypeHint (Whem -> When)

Signed-off-by: behappyleee <72903623+behappyleee@users.noreply.github.com>
@behappyleee behappyleee force-pushed the typo-instrumentedmethodtests-test-method-name branch from 4a9b101 to c191a54 Compare November 15, 2025 19:23
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 15, 2025
@bclozel
Copy link
Member

bclozel commented Nov 17, 2025

This was fixed already in #35815; please update your branch before submitting PR, your branch is almost a year old

commit c191a548c23bb3e084da50cf6f0d706a3c27b6df (HEAD -> typo-instrumentedmethodtests-test-method-name)
Author: behappyleee <72903623+behappyleee@users.noreply.github.com>
Date:   Sun Nov 16 04:21:18 2025 +0900

    typo: classGetConstructorsShouldNotMatchWhemMissingTypeHint -> classGetConstructorsShouldNotMatchWhenMissingTypeHint (Whem -> When)

    Signed-off-by: behappyleee <72903623+behappyleee@users.noreply.github.com>

commit 88a5b4efd339ec544aede823611944e56658799f
Merge: 1ef7e70950 52006b71bc
Author: Brian Clozel <brian.clozel@broadcom.com>
Date:   Wed Dec 11 16:12:01 2024 +0100

    Merge branch '6.2.x'

@bclozel bclozel closed this Nov 17, 2025
@bclozel bclozel added status: invalid An issue that we don't feel is valid and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 17, 2025
@behappyleee
Copy link
Author

behappyleee commented Nov 17, 2025

Thank you for pointing this out. My branch was indeed outdated — I’ll update it accordingly. Appreciate the guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: invalid An issue that we don't feel is valid

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@behappyleee @bclozel @spring-projects-issues