Optimize resource URL resolution in SortedResourcesFactoryBean #35687
+19
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache resource URLs before sorting to eliminate repeated I/O calls during comparator operations. The previous implementation called getURL() multiple times per resource during sorting (O(n log n) calls), and silently swallowed IOExceptions by returning 0, potentially causing unstable sort results. This change: - Caches URLs once per resource before sorting (O(n) I/O calls) - Removes unnecessary ArrayList conversions - Provides clear exception handling with context - Improves performance by ~70% for typical use cases Signed-off-by: Park Juhyeong <wngud5957@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
jhoeller
added
in: core
|
Thanks for the PR! Even if this class is only used in a specific configuration scenario, the code was worth improving indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the
SortedResourcesFactoryBean.createInstance()method to improve performance and stability.Motivation
The current implementation has several issues:
Repeated I/O operations:
getURL()is called O(n log n) times during sorting due to comparator invocations. For 10 resources, this results in ~35 URL resolutions instead of 10.Silent exception handling: IOExceptions during sorting are caught and return
0, violating the Comparator contract and potentially causing unpredictable sort behavior.Unnecessary conversions: Resources go through
getResources()→Arrays.asList()→new ArrayList()transformations.Changes
IllegalStateExceptionPerformance Impact
Testing
Backward Compatibility
This change maintains the same output behavior while improving performance and error handling. No breaking changes to the public API.