Allow explicitly declared null in providedArgs when no argument resolver matches #35192
+42
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2025 09:53
…en no suitable argument resolver exists Previously, when no HandlerMethodArgumentResolver supported a method parameter, and `null` was explicitly provided in `providedArgs`, the framework would throw an IllegalStateException. This commit improves the robustness of argument resolution in `InvocableHandlerMethod#getMethodArgumentValues` by accepting explicitly passed `null` values, even when no resolver is available. Issue: spring-projects#35067
…en no suitable argument resolver exists Previously, when no HandlerMethodArgumentResolver supported a method parameter, and `null` was explicitly provided in `providedArgs`, the framework would throw an IllegalStateException. This commit improves the robustness of argument resolution in `InvocableHandlerMethod#getMethodArgumentValues` by accepting explicitly passed `null` values, even when no resolver is available. Issue: spring-projects#35067
spring-projects-issues
added
the
status: waiting-for-triage
mengnankkkk
reviewed
Jul 13, 2025
| @@ -218,6 +218,10 @@ public void setMethodValidator(@Nullable MethodValidator methodValidator) { | |||
| continue; | |||
| } | |||
| if (!this.resolvers.supportsParameter(parameter)) { | |||
| if (isParameterDeclaredButNull(parameter, providedArgs)) { | |||
| args[i] = null; | |||
There was a problem hiding this comment.
The new isParameterDeclaredButNull method checks if a parameter is explicitly set to null in providedArgs and assigns null directly, bypassing the exception. While this improves compatibility in some cases, it may hide the real cause of argument resolution failures, reducing code robustness and maintainability.
| @Test | ||
| void nullHandlerMethod() throws Exception { | ||
| standaloneSetup(new PersonController()).setControllerAdvice(new GlobalExceptionHandler()).build() | ||
| .perform(get("/invalid")) |
There was a problem hiding this comment.
The test only covers the scenario where handlerMethod is null, but does not cover multiple parameters, complex types, or nested parameters. Additional tests are suggested.
rstoyanchev
reviewed
Jul 15, 2025
rstoyanchev
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses an issue where
InvocableHandlerMethod#getMethodArgumentValuesthrows anIllegalStateExceptionwhen a method parameter is not supported by any
HandlerMethodArgumentResolverandnullis explicitly provided inprovidedArgs.What this PR does
isParameterDeclaredButNull(...)to tolerate explicitnullvaluesprovidedArgsis interpreted as a deliberate argument, avoiding spurious resolution failuresWhy this is useful
In practice, this improves error handler behavior, especially for
@ExceptionHandlerwhere the HandlerMethod can benull.Related issue
Fixes #35067