Skip to content

Introduce Stream variant methods for SqlQuery #34623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

Introduce Stream variant methods for SqlQuery #34623

merged 1 commit into from
Mar 21, 2025

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Mar 20, 2025

Closes GH-34474

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 20, 2025
@jhoeller
Copy link
Contributor

On review, could we simply name those methods stream(...) instead? And then also introduce streamByNamedParam equivalents next to the existing executeByNamedParam methods.

@quaff
Introduce Stream variant methods for SqlQuery
2745eab 
Closes spring-projectsGH-34474

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@quaff
Copy link
Contributor Author

quaff commented Mar 21, 2025

On review, could we simply name those methods stream(...) instead? And then also introduce streamByNamedParam equivalents next to the existing executeByNamedParam methods.

Updated, please review.

@jhoeller jhoeller mentioned this pull request Mar 21, 2025
Closed
@jhoeller jhoeller added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 21, 2025
@jhoeller jhoeller self-assigned this Mar 21, 2025
@jhoeller jhoeller added this to the 7.0.0-M4 milestone Mar 21, 2025
@jhoeller jhoeller merged commit 8819c74 into spring-projects:main Mar 21, 2025
4 checks passed
@jhoeller
Copy link
Contributor

Looks great! Thanks for your efforts.

jhoeller added a commit that referenced this pull request Mar 21, 2025
@jhoeller
Add since 7.0 tags for stream methods
7d5b389 
See gh-34623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhoeller jhoeller

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.0-M4
Development

Successfully merging this pull request may close these issues.

Introduce Stream variant methods for SqlQuery
3 participants
@quaff @jhoeller @spring-projects-issues