Skip to content

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Nov 26, 2024

See GH-33935

@sbrannen
Copy link
Member

sbrannen commented Dec 2, 2024

Thanks for the PR, @quaff. 👍

However, if we're going to do this, we shouldn't do it only for wrapping. Instead, we should improve the diagnostics for all such cases.

I'm therefore closing as:

@quaff, if you want to submit a PR for #34004, feel free, and I can assist you with addressing the topic consistently for all use cases. Or... I can pick it up. I'll leave it up to you. 😉

@sbrannen sbrannen closed this Dec 2, 2024
@sbrannen sbrannen added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 2, 2024
@quaff
Copy link
Contributor Author

quaff commented Dec 3, 2024

@quaff, if you want to submit a PR for #34004, feel free, and I can assist you with addressing the topic consistently for all use cases. Or... I can pick it up. I'll leave it up to you. 😉

Yes, I'd like to submit a PR, please review #34006 @sbrannen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants