Update HttpHeaders.setHost() to actually remove the Host header
#33716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bivo Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@bivo Thank you for signing the Contributor License Agreement! |
…hod not deleting the host
bivo
force-pushed
the
bugfix/set-host-method-does-not-delete-host
branch
from
21e9457 to
6398b1a
Compare
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
the
in: web
rstoyanchev
added
type: bug
rstoyanchev
changed the title
HttpHeaders.setHost() method not deleting the hostHttpHeaders.setHost() to actually remove the Host header
rstoyanchev
pushed a commit
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
org.springframework.http.HttpHeadersclass.It was not possible to delete/clear the
Hostheader before this fix.This bug was first introduced in this commit (in 2018): 5bbbc82#diff-e2d6218e6585f8b7e32682f6f8f7aed22dbd76d862ec92e86e0902243889556aR1020
After that commit, the deletion logic line in
setHost()method started to look like this:remove(HOST, null)Although for all other methods/headers it looks like this:
remove(CONTENT_TYPE),remove(ETAG), etc.And for
setHost()method it also should be the same:remove(HOST)I've also added a test for this case. Feel free to rollback my 1-line fix in
HttpHeadersand check thatHostheader is not cleared indeed.