Combine if-statements in ScopedProxyBeanDefinitionDecorator
#31847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
@achhibi as I've mentioned previously, we prefer to do such stylistic code change ourselves in general. I am going to merge this one but please take the above in consideration going forward. |
snicoll
added
type: task
snicoll
changed the title
snicoll
added a commit
that referenced
this pull request
Dec 15, 2023
snicoll
added a commit
that referenced
this pull request
Dec 15, 2023
* pr/31847: Upgrade copyright year of changed file Combine conditions for better readability and simplicity Closes gh-31847
Contributor
Author
|
@snicoll Thank you for taking the time to review; I will take your feedback into consideration. |
sbrannen
changed the title
ScopedProxyBeanDefinitionDecorator
sbrannen
added
the
in: core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the code and makes it more readable by combining two conditions into a single statement using the logical AND operator (
&&). Now, the enclosed statement executes only when both conditions (aandb) aretrue.Your review and consideration for merging are appreciated to improve overall code quality.