Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve to empty MultiValueMap when no matrix variables are provided #31483

Conversation

bernie-schelberg-invicara

When no matrix variables are provided to an endpoint with a MultiValueMap parameter, the argument should resolve to a MultiValueMap, not to Collections.emptyMap().

@pivotal-cla
Copy link

@bernie-schelberg-invicara Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 24, 2023
@pivotal-cla
Copy link

@bernie-schelberg-invicara Thank you for signing the Contributor License Agreement!

@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 24, 2023
@snicoll snicoll self-assigned this Oct 24, 2023
@snicoll snicoll modified the milestones: 6.1.0-RC2, 6.0.14 Oct 24, 2023
@sbrannen sbrannen changed the title Resolve to MultiValueMap when no matrix variables Resolve to empty MultiValueMap when no matrix variables are provided Oct 24, 2023
@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Oct 24, 2023
snicoll pushed a commit that referenced this pull request Oct 24, 2023
@snicoll snicoll closed this in 33fba8e Oct 24, 2023
@snicoll snicoll added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x labels Oct 24, 2023
@snicoll
Copy link
Member

snicoll commented Oct 24, 2023

@bernie-schelberg-invicara good catch and thank you for making your first contribution to Spring Framework. I've harmonized the method so that it has to return a MultiValueMap for consistency. I've also adapted the reactive variant. See 9aa707e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants