-
Notifications
You must be signed in to change notification settings - Fork 38.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo and use of componentry #27852
Conversation
@@ -134,7 +134,7 @@ | |||
* setting of the <em>thread name prefix</em> of the {@code Executor}; this is because | |||
* the {@code <task:executor>} element does not expose such an attribute. This | |||
* demonstrates how the JavaConfig-based approach allows for maximum configurability | |||
* through direct access to actual componentry. | |||
* through direct access to actual component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a typo: "componentry" is semantically correct here.
Although the wording could be improved, the suggested change is grammatically incorrect.
@@ -180,7 +180,7 @@ | |||
* instead of a custom <em>{@code Trigger}</em> implementation; this is because the | |||
* {@code task:} namespace {@code scheduled} cannot easily expose such support. This is | |||
* but one demonstration how the code-based approach allows for maximum configurability | |||
* through direct access to actual componentry. | |||
* through direct access to actual component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a typo: "componentry" is semantically correct here.
Although the wording could be improved, the suggested change is grammatically incorrect.
@@ -129,7 +129,7 @@ | |||
* method will be invoked on each instance, delegating the {@code ServletContext} such | |||
* that each instance may register and configure servlets such as Spring's | |||
* {@code DispatcherServlet}, listeners such as Spring's {@code ContextLoaderListener}, | |||
* or any other Servlet API componentry such as filters. | |||
* or any other Servlet API component such as filters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a typo: "componentry" is semantically correct here.
Although the wording could be improved, the suggested change is grammatically incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you review but can I ask a question in this word "component" change to the "componentry" means, because componentry is not in the dictionary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a typo: "componentry" is semantically correct here.
Although the wording could be improved, the suggested change is grammatically incorrect.
I am also not the English native speaker,I can not understand at the word add ry means what,so how to change the word can grammatically correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what dictionary are you using?
https://www.dictionary.com/browse/componentry
IMO, it is worth reviewing as the current phrasing isn't friendly to those, like me, who aren't English native speaker. |
@xixingya thanks for spotting these, I hope the polished phrasing is more accessible to everyone. |
👍
Yep, it's definitely more accessible to non-native speakers like that. Thanks. |
Fix lattery and componentry word