Skip to content

Rename earlyProxyReferences to earlyBeanReferences in AbstractAutoProxyCreator #23914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Rename earlyProxyReferences to earlyBeanReferences in AbstractAutoProxyCreator #23914

wants to merge 1 commit into from

Conversation

chenqimiao
Copy link
Contributor

The original map named earlyProxyReferences seems to stores the target object, not the proxy object.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 3, 2019
@chenqimiao chenqimiao closed this Nov 8, 2019
@chenqimiao chenqimiao deleted the feature/pr branch November 8, 2019 14:18
@chenqimiao chenqimiao restored the feature/pr branch November 8, 2019 14:22
@chenqimiao chenqimiao reopened this Nov 8, 2019
@sbrannen sbrannen requested a review from jhoeller November 9, 2019 14:21
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task labels Nov 9, 2019
@snicoll snicoll changed the title Modify the name of map earlyProxyReferences to earlyTargetReferences Rename earlyProxyReferences to earlyBeanReferences in AbstractAutoProxyCreator Aug 23, 2023
@snicoll snicoll removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 23, 2023
@snicoll snicoll self-assigned this Aug 23, 2023
@snicoll snicoll added this to the 6.1.0-RC1 milestone Aug 23, 2023
snicoll pushed a commit that referenced this pull request Aug 23, 2023
@chenqimiao @snicoll
Rename earlyProxyReferences in AbstractAutoProxyCreator
67e3b1b 
See gh-23914
snicoll added a commit that referenced this pull request Aug 23, 2023
@snicoll
Polish "Rename earlyProxyReferences in AbstractAutoProxyCreator"
5d5cd17 
See gh-23914
@snicoll snicoll closed this in 8f6d24e Aug 23, 2023
@snicoll
Copy link
Member

snicoll commented Aug 23, 2023

Thanks @chenqimiao. For consistency with the method that fills the cache, I've renamed that to earlyBeanReferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoeller jhoeller Awaiting requested review from jhoeller

Assignees

@snicoll snicoll

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Milestone
6.1.0-M5
Development

Successfully merging this pull request may close these issues.
4 participants
@chenqimiao @snicoll @sbrannen @spring-projects-issues