Some trivial optimization in method populateBean() #22792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cenjieHo Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@cenjieHo Thank you for signing the Contributor License Agreement! |
hecenjie
changed the title
spring-projects-issues
added
the
status: waiting-for-triage
Optimize the number of getResolvedAutowireMode() method calls
hecenjie
changed the title
sbrannen
added
the
in: core
jhoeller
added
type: enhancement
|
Thanks for raising this! Even if such field access through method calls is usually very efficient at runtime, this is worth changing for clarification purposes in any case: namely evaluating the same state of the field, never getting a different autowire mode returned from that getter. A one-time method call with a locally cached result makes this clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think it's necessary to call the same get method so many times, maybe can do some trivial optimization here.