SPR-15218 - Add logging to processPropertySource() (Obvious Fix) #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log at debug level if property source cannot be processed and ignoreResourceNotFound = true. Issue: SPR-15218
snicoll
changed the title
Contributor
|
I've adopted your suggestion in a slightly different fashion, including alignment with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set amends ConfigurationClassParser.processPropertySource() to log a message at debug level when a PropertySource with ignoreResourceNotFound = true cannot be loaded for any reason.
Detailed justification for this change, including a link to an illustrative project, may be found on the JIRA:
https://jira.spring.io/browse/SPR-15218
I believe this qualifies as an "obvious fix" which does not require a CLA signature according to the following document:
https://cla.pivotal.io/about#obvious-fixes