Support "request message id as response correlation id" in MessageListenerAdapter [SPR-4647]

[spring-projects-issues]

Cyrille Le Clerc opened SPR-4647 and commented

Enhance MessageListenerAdapter to support "request message id as response correlation id" in addition to the current behavior that use "request correlation id as response correlation id".

"Request JMSMessageID as response JMSCorrelationID" becomes a kind of de-facto standard implementation of the JMS Request/Reply pattern :

• Enterprise Integration Patterns : JMS Request/Reply Example [1]
• Spring WS's JMS transport (see JmsReceiverConnection)
• SOAP over Java Message Service 1.0 RC1 : specification proposal by BEA, IBM, Sonic Software and Tibco [2]
• CXF, Axis2, JAXWS-RI, Websphere, etc use it for their JMS transport

[1] http://enterpriseintegrationpatterns.com/RequestReplyJmsExample.html
[2] http://mail-archives.apache.org/mod_mbox/ws-axis-dev/200701.mbox/raw/%3C80A43FC052CE3949A327527DCD5D6B27020FB65C@MAIL01.bedford.progress.com%3E/3

---

Affects: 2.5.2

Attachments:

• SPR-4647.patch (14.19 kB)

Issue Links:

• Implement synchronous request / response logic in JmsTemplate [SPR-3332] #8017 Implement synchronous request / response logic in JmsTemplate

2 votes, 3 watchers

[spring-projects-issues]

Juergen Hoeller commented

We have plans to provide more comprehensive support for the request-reply pattern in Spring 2.5.4 - also at the JmsTemplate level. See #8017 for a discussion about the JmsTemplate level there.

Juergen

[spring-projects-issues]

Cyrille Le Clerc commented

Here is a patch to support "Request Message Id as Response Correlation Id" in MessageListenerAdapter.

List of modifications :

• MessageListenerAdapter.java :

  • Add field useMessageIdInResponse as boolean
  • Enhance "postProcessResponse(Message request, Message response)" to use JMSMessageID instead of JMSCorrelationID if useMessageIdInResponse is true

• spring-jms-2.5.xsd : add "use-message-id-in-response" attribute to "listenerType"

• AbstractListenerContainerParser.java : handle "use-message-id-in-response" xml attribute

• MessageListenerAdapterTests.java : add "testWithResponsiveMessageDelegateNoDefaultDestination_SendsReturnTextMessageUseMessageIdInResponseWhenSessionSupplied()" to check request's JMSMessageId as response's JMSCorrelationID

[spring-projects-issues]

Juergen Hoeller commented

I eventually decided to go for an automatic fallback instead of explicit configuration: MessageListenerAdapter and JmsInvokerServiceExporter use the message id as correlation id if no request correlation id has been set. So if not setting the request correlation id explicitly, the response correlation id will automatically be set to the request message id - without any special configuration...

Juergen