Clients created using JdkClientHttpRequestFactory set content-length for GET, DELETE and HEAD requests

[zkorhone]

Current implementation that builds HTTP client request is:

builder.method(this.method.name(), bodyPublisher(headers, body));

This results in creating a GET request without a body.

This however isn't internally the same as not setting publisher at all (openjdk/jdk@6a77093).

Unfortunately you must always pass the published for this method. While you could file a bug against JDK, getting a fix will take far longer than addressing this in Spring.

I believe what is required is to change Spring's algorithm to something that checks if there is a body and if the request method is one of GET, DELETE, or HEAD. If it is, then one should call matching method in the request builder.

[bclozel]

Thanks for the report @zkorhone
It seems this behavior change has been introduced in Java 19. We'll use the HTTP method variants whenever possible to help with that.

We could improve the situation somehow if the java.net.http.HttpRequest.Builder#method method allowed null publishers. This would help make the difference between an "empty body" and "no body at all". After all, the method0 variant does allow null body publishers for the GET and DELETE cases. Could you raise a JDK issue for this please? I think you would be in a better position to make this case as you've encountered this problem yourself.

[zkorhone]

@bclozel Assuming that process of reporting bugs isn't that bad for jdk, I'll file an issue regarding to this. I guess it's then up to their interpretation if they consider this to be a bug or a feature.

If they did consider it a feature, it would be nice to have behavior documented.