Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultPartHttpMessageReader should not instantiate Reactor Scheduler eagerly #33218

Closed
rstoyanchev opened this issue Jul 15, 2024 · 0 comments
Closed
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

A Spring for GraphQL application may initialize and use a CodecConfigurer for small (de)-serialization needs such as turning pagination cursors to a string, usually via JSON. This is done via codecs for both Spring MVC and WebFlux as the transport to keep the configuration model .

This works fine except when CodecConfigurer is created, DefaultPartHttpMessageConverter creates a newBounded scheduler at constructor time, which can be surprising, and in this scenario no multipart reading will be done. We can initializer the scheduler lazily at runtime.

@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Jul 15, 2024
@rstoyanchev rstoyanchev added this to the 6.2.0-M6 milestone Jul 15, 2024
@rstoyanchev rstoyanchev self-assigned this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant