Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize ContentCachingRequestWrapper allocation for known request size #31834

Closed
bclozel opened this issue Dec 13, 2023 · 0 comments
Closed

Optimize ContentCachingRequestWrapper allocation for known request size #31834

bclozel opened this issue Dec 13, 2023 · 0 comments
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.1.2

Comments

@bclozel
Copy link
Member

bclozel commented Dec 13, 2023

See #29775 (comment)

This should also build on top of #31737
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Dec 13, 2023
@bclozel bclozel added this to the 6.1.2 milestone Dec 13, 2023
@bclozel bclozel self-assigned this Dec 13, 2023
bclozel added a commit that referenced this issue Jun 10, 2024
@bclozel
Restrict memory allocation in ContentCachingRequestWrapper
0ca393c 
Prior to this commit, the `ContentCachingRequestWrapper` could allocate
a `FastByteArrayOutputStream` block that was larger than the content
cache limit given as a consturctor argument. This was due to an
optimization applied in gh-31834 for allocating the right content cache
size when the request size is known.

Fixes gh-32987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.2
Development

No branches or pull requests
1 participant
@bclozel