MockHttpServletResponse.getDateHeader fails with NPE for non-existing header [SPR-16160]

[spring-projects-issues]

Juergen Hoeller opened SPR-16160 and commented

MockHttpServletResponse.getDateHeader doesn't check for the existence of the corresponding header and ends up calling DateFormat.parse with a null value. Aligned with HttpServletRequest.getDateHeader(), it should simply return -1 in such a case.

---

Affects: 4.3.12, 5.0.1

Issue Links:

• MockHttpServletRequest with Host: set builds wrong getRequestURL() [SPR-16138] #20686 MockHttpServletRequest with Host: set builds wrong getRequestURL()
• Consider using ZonedDateTime in HttpHeaders [SPR-15661] #20220 Consider using ZonedDateTime in HttpHeaders

Referenced from: commits a75dd2d, 80a0cf7, dc0a934

Backported to: 4.3.13

[spring-projects-issues]

Juergen Hoeller commented

As far as possible, we're also using MockHttpServletResponse.getDateHeader within our own tests now instead of trying to match the concrete date presentation in the textual header value.